-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Termux subsystem #63
Support for Termux subsystem #63
Conversation
src/platformdirs/android.py
Outdated
@@ -18,7 +18,7 @@ class Android(PlatformDirsABC): | |||
@property | |||
def user_data_dir(self) -> str: | |||
""":return: data directory tied to the user, e.g. ``/data/user/<userid>/<packagename>/files/<AppName>``""" | |||
return self._append_app_name_and_version(_android_folder(), "files") | |||
return self._append_app_name_and_version(_android_folder() or "", "files") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the or here? I've understood that when this is called it's guaranteed that it will be not None, not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tox -e type
swears
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy
knows less than we, but probably a typing.cast
for mypy likely is better choice than or
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, i think so too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sir when I put these 2 files manually in _vendor/platformdirs/ folder it fixes my problem😊
Thanks gentleman, this works for me. |
pls can you tell me which two files are needed to be added to solve this problem.Iam facing this problem in my ubuntu jammy installed in termux using proot-distro. |
thanks,it works for my termux ! |
Fix of #62
Platformdirs on Termux under Arch Linux subsystem:
Platformdirs on Termux: